linux-kernel - Re: [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aPPo7VWm4HyoHSIE@ashevche-desk.local>
Date: Sat, 18 Oct 2025 22:22:21 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jinhui Guo <guojinhui.liam@...edance.com>
Cc: mika.westerberg@...ux.intel.com, jsd@...ihalf.com,
	andi.shyti@...nel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent
 storms from mis-configured firmware


On Sat, Oct 11, 2025 at 03:30:57PM +0800, Jinhui Guo wrote:
> When probing the I2C master, disable SMBus interrupts to prevent
> storms caused by broken firmware mis-configuring IC_SMBUS=1; the
> handler never services them and a mis-configured SMBUS Master
> extend-clock timeout can flood the CPU.

...

>  #define DW_IC_TX_ABRT_SOURCE			0x80
>  #define DW_IC_ENABLE_STATUS			0x9c
>  #define DW_IC_CLR_RESTART_DET			0xa8
> +#define DW_IC_SMBUS_INTR_MASK		0xcc

It seems one TAB too little.

>  #define DW_IC_COMP_PARAM_1			0xf4
>  #define DW_IC_COMP_VERSION			0xf8
>  #define DW_IC_SDA_HOLD_MIN_VERS			0x3131312A /* "111*" == v1.11* */

...

The rest LGTM, but let Mika to review.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko