linux-kernel - Re: [PATCH v13 2/2] iio: adc: max14001: New driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251018203038.40084197@jic23-huawei>
Date: Sat, 18 Oct 2025 20:30:38 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: Marilene Andrade Garcia <marilene.agarcia@...il.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, Kim Seer Paller <kimseer.paller@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Marcelo Schmitt
 <Marcelo.Schmitt@...log.com>, Ceclan Dumitru <dumitru.ceclan@...log.com>,
 Jonathan Santos <Jonathan.Santos@...log.com>, Dragos Bogdan
 <dragos.bogdan@...log.com>
Subject: Re: [PATCH v13 2/2] iio: adc: max14001: New driver

On Thu, 16 Oct 2025 23:09:31 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 10/15, Marilene Andrade Garcia wrote:
> > The MAX14001/MAX14002 is configurable, isolated 10-bit ADCs for multi-range
> > binary inputs. In addition to ADC readings, the MAX14001/MAX14002 offers
> > more features, like a binary comparator, a filtered reading that can
> > provide the average of the last 2, 4, or 8 ADC readings, and an inrush
> > comparator that triggers the inrush current. There is also a fault feature
> > that can diagnose seven possible fault conditions. And an option to select
> > an external or internal ADC voltage reference.
> > 
> > MAX14001/MAX14002 features implemented so far:
> > - Raw ADC reading.
> > - MV fault disable.
> > - Selection of external or internal ADC voltage reference, depending on
> > whether it is declared in the device tree.
> > 
> > Co-developed-by: Kim Seer Paller <kimseer.paller@...log.com>
> > Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> > Signed-off-by: Marilene Andrade Garcia <marilene.agarcia@...il.com>
> > Tested-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> > ---  
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> 
> Hmm, I don't know why, but I would have given a different order to the tags
> Reviewed-by: M. S. <...> # new tag
> Tested-by: M. S. <...>
> Co-developed-by: K. S. P. <...>
> Signed-off-by: K. S. P. <...>
> Signed-off-by: M. A. G. <...>
> 
> Swapping tag lines will probably not be a reason for a v14, though.

There have been many debates on this but no clear rules wrt to whether
review / testing tags should go earlier (on basis the sign off occurs
after them if they were on a previous version) or just put them all at the end.

Meh. All the right info is here so I'll just leave it be.

Series applied to the togreg branch of iio.git. Initially pushed out as
testing to let the autobuilders play with it.

Thanks,

Jonathan

> 
> Cheers,
> Marcelo