linux-kernel - Re: [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag insertion offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e45a8124-ace8-40bf-b55f-56dc8fbe6987@altera.com>
Date: Sat, 18 Oct 2025 07:26:30 +0530
From: "G Thomas, Rohan" <rohan.g.thomas@...era.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <Jose.Abreu@...opsys.com>,
 Rohan G Thomas <rohan.g.thomas@...el.com>,
 Boon Khai Ng <boon.khai.ng@...era.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag
 insertion offload

Hi Russell,

On 10/17/2025 6:12 PM, Russell King (Oracle) wrote:
> On Fri, Oct 17, 2025 at 02:11:19PM +0800, Rohan G Thomas via B4 Relay wrote:
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 650d75b73e0b0ecd02d35dd5d6a8742d45188c47..dedaaef3208bfadc105961029f79d0d26c3289d8 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -4089,18 +4089,11 @@ static int stmmac_release(struct net_device *dev)
>>   static bool stmmac_vlan_insert(struct stmmac_priv *priv, struct sk_buff *skb,
>>   			       struct stmmac_tx_queue *tx_q)
>>   {
>> -	u16 tag = 0x0, inner_tag = 0x0;
>> -	u32 inner_type = 0x0;
>> +	u16 tag = 0x0;
>>   	struct dma_desc *p;
> 
> #include <stdnetdevcodeformat.h> - Please maintain reverse christmas-
> tree order.

Thanks for pointing this out. I'll fix the declaration order in the next 
revision.

> 
> I haven't yet referred to the databook, so there may be more comments
> coming next week.
> 

Sure! Will wait for your feedback before sending the next revision.

Best Regards,
Rohan