linux-kernel - Re: [PATCH] iio: adc: qcom-vadc-common: fix vadc_scale_fn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251019094458.141971a7@jic23-huawei>
Date: Sun, 19 Oct 2025 09:44:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Linus Walleij <linus.walleij@...aro.org>,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: qcom-vadc-common: fix vadc_scale_fn_type
 kernel-doc

On Fri, 17 Oct 2025 00:07:27 -0700
Randy Dunlap <rdunlap@...radead.org> wrote:

> Fix multiple warnings in enum vadc_scale_fn_type by adding a leading
> '@' to the kernel-doc descriptions.
> 
> Fixed 14 warnings in this one enum, such as:
> Warning: include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
>  'SCALE_DEFAULT' not described in enum 'vadc_scale_fn_type'
> Warning: ../include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
>  'SCALE_THERM_100K_PULLUP' not described in enum 'vadc_scale_fn_type'
> Warning: ../include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
>  'SCALE_PMIC_THERM' not described in enum 'vadc_scale_fn_type'
> 
> Also prevent the warning on SCALE_HW_CALIB_INVALID by marking it
> "private:" so that kernel-doc notation is not needed for it.
> 
> This leaves only one warning here, which I don't know the
> appropriate description of:
> qcom-vadc-common.h:125: warning: Enum value
>  'SCALE_HW_CALIB_PMIC_THERM_PM7' not described in enum 'vadc_scale_fn_type'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Thanks for cleaning this up. Hopefully someone else will follow up
with the description for the missing one.

Applied,

Jonathan


>