linux-kernel - Re: [PATCH v4 0/2] iio: humditiy: hdc3020: fix units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251019094849.0b904e2c@jic23-huawei>
Date: Sun, 19 Oct 2025 09:48:49 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Dimitri Fedrau via B4 Relay
 <devnull+dimitri.fedrau.liebherr.com@...nel.org>
Cc: dimitri.fedrau@...bherr.com, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, Li peiyu <579lpy@...il.com>, David
 Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Dimitri Fedrau
 <dima.fedrau@...il.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Chris Lesiak
 <chris.lesiak@...orbio.com>
Subject: Re: [PATCH v4 0/2] iio: humditiy: hdc3020: fix units

On Thu, 16 Oct 2025 07:20:37 +0200
Dimitri Fedrau via B4 Relay <devnull+dimitri.fedrau.liebherr.com@...nel.org> wrote:

> Fix units to milli degree celsius and milli percent for temperature
> respectively relative humidity measurements and thresholds.
> 
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Hi Dimitri,

I think this covers the last bits of feedback so I'll queue it up in the
fixes-togreg branch of iio.git.  I'll probably not send a pull request
for that for a few more days though so there is still time for additional
feedback.

Also marked for stable.

Thanks

Jonathan

> ---
> Changes in v4:
> - Add explicit formula into comments of hdc3020_thresh_get_temp and
>   hdc3020_thresh_get_hum
> - Add explicit division by 5 into calculations in hdc3020_thresh_get_temp
>   and hdc3020_thresh_get_hum
> - Link to v3: https://lore.kernel.org/r/20251013-hdc3020-units-fix-v3-0-b21fab32b882@liebherr.com
> 
> Changes in v3:
> - Fix verbose comment for define HDC3020_THRESH_FRACTION (Javier)
> - Embed prescale into define HDC3020_THRESH_FRACTION to make the division
>   by 5 calculation in threshold calculations explicit. (Andy)
> - Add resulting units into comments again in hdc3020_thresh_get_temp and
>   hdc3020_thresh_get_hum (Andy)
> - Link to v2: https://lore.kernel.org/r/20250901-hdc3020-units-fix-v2-0-082038a15917@liebherr.com
> 
> Changes in v2:
> - Added explanation what is wrong at the moment into commit msg
> - Added define HDC3020_THRESH_FRACTION and comment at the beginning of the
>   code.
> - Use MILLI for instead of hardcoded 1000.
> - Link to v1: https://lore.kernel.org/r/20250821-hdc3020-units-fix-v1-0-6ab0bc353c5e@liebherr.com
> 
> ---
> Dimitri Fedrau (2):
>       iio: humditiy: hdc3020: fix units for temperature and humidity measurement
>       iio: humditiy: hdc3020: fix units for thresholds and hysteresis
> 
>  drivers/iio/humidity/hdc3020.c | 73 +++++++++++++++++++++++++-----------------
>  1 file changed, 43 insertions(+), 30 deletions(-)
> ---
> base-commit: 875e7d357a7f2e77a7f3fc4759d0aa0872c33027
> change-id: 20250820-hdc3020-units-fix-91edbb8ccd07
> 
> Best regards,