linux-kernel - Re: [PATCH 0/2] Adding support for Microchip PAC1711

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251019113146.74c3f236@jic23-huawei>
Date: Sun, 19 Oct 2025 11:31:46 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Ariana Lazar <ariana.lazar@...rochip.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, "Andy Shevchenko" <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, <linux-iio@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Guenter Roeck
 <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 0/2] Adding support for Microchip PAC1711

On Wed, 15 Oct 2025 13:12:14 +0300
Ariana Lazar <ariana.lazar@...rochip.com> wrote:

> The PAC1711 product is a single-channel power monitor with accumulator.
> The device uses 12-bit resolution for voltage and current measurements and
> 24 bits power calculations. The accumulator register (56-bit) could
> accumulate power (energy), current (Coulomb counter) or voltage.
> 
> PAC1711 measures up to 42V Full-Scale Range.

Hi Ariana,

For devices like this where the datasheet explicitly calls out usecases in
power monitoring e.g. for "Portable and Embedded Computing" (amongst other
things) there is always a question to answer wrt to whether the correct
place to support them in Linux is in hwmon or IIO. Note that, whilst this
has long been an informal policy I've become more strict on this after some
concerns were raised in the last cycle - the presence of similar devices
in IIO isn't necessarily a sign that was the right choice, but it is worth
looking at the history of those divers as it may provide more insight into
why they are in IIO.

To address that we ask that:
1) Drivers for this sort of potentially borderline device are +CC to hwmon
   list and maintainers
2) A justification for IIO making more sense is included. That can be
   based on what cannot be supported in hwmon (high speed capture being
   a typical item - that doesn't seem to apply here as it's only 200 sample/sec)

Anyhow, I've +CC relevant folk so if you can reply with that info here then
that would be great.

Thanks,

Jonathan

> 
> Signed-off-by: Ariana Lazar <ariana.lazar@...rochip.com>
> ---
> Ariana Lazar (2):
>       dt-bindings: iio: adc: adding support for PAC1711
>       iio: adc: adding support for PAC1711
> 
>  .../ABI/testing/sysfs-bus-iio-adc-pac1711          |   57 +
>  .../bindings/iio/adc/microchip,pac1711.yaml        |  195 +++
>  MAINTAINERS                                        |    8 +
>  drivers/iio/adc/Kconfig                            |   10 +
>  drivers/iio/adc/Makefile                           |    1 +
>  drivers/iio/adc/pac1711.c                          | 1448 ++++++++++++++++++++
>  6 files changed, 1719 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250901-pac1711-d3bacda400fd
> 
> Best regards,