linux-kernel - Re: [PATCH v3 1/3] arm64: dts: nuvoton: fix warning and nodes order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc23d41d-6a5e-44d7-ad4b-1b39566dbce8@kernel.org>
Date: Sun, 19 Oct 2025 12:35:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tomer Maimon <tmaimon77@...il.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, avifishman70@...il.com, tali.perry1@...il.com,
 joel@....id.au, venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com
Cc: openbmc@...ts.ozlabs.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: nuvoton: fix warning and nodes order

On 25/09/2025 22:06, Tomer Maimon wrote:
> Fix the warning in the gcr and timer nodes, and modify nodes order by

What warning?

> ascending unit address.

Why are you combining multiple issues into one commit. No. Read
submitting patches how to organize your work.

> 
> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
> ---
>  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 35 +++++++++----------
>  1 file changed, 17 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 24133528b8e9..a43514f624c0 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -18,7 +18,7 @@ soc {
>  		ranges;
>  
>  		gcr: system-controller@...00000 {
> -			compatible = "nuvoton,npcm845-gcr", "syscon";
> +			compatible = "nuvoton,npcm845-gcr", "syscon", "simple-mfd";

This makes no sense. No children here.

>  			reg = <0x0 0xf0800000 0x0 0x1000>;
>  		};
>  
Best regards,
Krzysztof