linux-kernel - Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s2u4wktoi26b5yjfl52j4y53r2bgtwsryacjd22smidl4kbtsj@ahiqbwgrcpif>
Date: Sun, 19 Oct 2025 14:57:13 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Taniya Das <taniya.das@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Ajit Pandey <ajit.pandey@....qualcomm.com>,
        Imran Shaik <imran.shaik@....qualcomm.com>,
        Jagadeesh Kona <jagadeesh.kona@....qualcomm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC_8750 from m to
 y

On Fri, Oct 17, 2025 at 10:46:43AM +0530, Taniya Das wrote:
> 
> 
> On 10/17/2025 10:00 AM, Krzysztof Kozlowski wrote:
> > On 16/10/2025 20:53, Taniya Das wrote:
> >> The TCSR clock controller is required  during boot to provide the ref
> >> clocks to the UFS controller. Setting CONFIG_SM_TCSRCC_8750 to y ensures
> >> the UFS driver successfully probe and initialize the device.
> >>
> >> Without this change, the UFS subsystem fails to mount as a usable file
> >> system during boot.
> > 
> > 
> > That's not what I observed. UFS works fine, especially that it is a
> > module, so no, this is not a desired change and explanation is not only
> > insufficient but actually incorrect.
> > 
> 
> Krzysztof, on Pakala MTP we are observing the below issue and it
> requires the module of tscrcc to be loaded explicitly. This patch also
> aligns to how it is on all other targets.
> 
> /soc@...hy@...0000: Failed to get clk index: 2 ret: -517
> [   10.496570] ufshcd-qcom 1d84000.ufs: freq-table-hz property not specified
> [   10.503660] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to
> find vdd-hba-supply regulator, assuming enabled
> [   10.514548] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to
> find vccq2-supply regulator, assuming enabled
> [   10.565955] platform 1d80000.phy: deferred probe pending: (reason
> unknown)
> [   10.573078] platform 1d84000.ufs: deferred probe pending:
> ufshcd-qcom: ufshcd_pltfrm_init() failed

This will also require you to set CONFIG_SCSI_UFS_QCOM=y (=m in
defconfig), CONFIG_PHY_QCOM_QMP_UFS=y (also =m in defconfig), etc. So, I
doubt that you are using defconfig as is. Please extend your
configuration in order to pick this module.

Note, defconfig is supposed to be used by multiple platforms and
multiple defice. As sych we can't enable all bootable devices. It is
expected that the users either change their configuration or use
initramfs. Only "working console" is expected to be working with the
defconfig and that's only because systemd doesn't reopen /dev/console
after probing modules. If it were, we could have moved all pinctrl,
interconnect and other similar drivers to =m in order to make the
footprint smaller for other platforms.

-- 
With best wishes
Dmitry