linux-kernel - Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPT0T-xN-ghoP4id@lonswws03.ad.cirrus.com>
Date: Sun, 19 Oct 2025 15:23:11 +0100
From: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 06/11] ASoC: dt-bindings: sound: cirrus: cs530x: Add
 cs530x variants

On Sun, Oct 19, 2025 at 12:32:20PM +0200, Krzysztof Kozlowski wrote:
> On 17/10/2025 18:15, Vitaly Rodionov wrote:
> > This patch adds additional cs530x family variants.
> > 
> > cirrus,cs4282 - high-performance, 32-bit resolution, stereo CODEC
> > cirrus,cs4302 - high performance stereo DAC, 2 channels
> > cirrus,cs4304 - high performance stereo DAC, 4 channels
> > cirrus,cs4308 - high performance stereo DAC, 8 channels
> > 
> > Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> > ---
> >  Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > index 9582eb8eb418..90a5cea0632d 100644
> > --- a/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > +++ b/Documentation/devicetree/bindings/sound/cirrus,cs530x.yaml
> > @@ -22,6 +22,10 @@ properties:
> >        - cirrus,cs5302
> >        - cirrus,cs5304
> >        - cirrus,cs5308
> > +      - cirrus,cs4282
> > +      - cirrus,cs4302
> > +      - cirrus,cs4304
> > +      - cirrus,cs4308
> 
> I asked about fixing this at v1. You ignored it. Then I reminded this at
> v3. You sent v4 still ignoring my comment.
> 
> I don't know what to do more.
> 
> NAK
> 
> Best regards,
> Krzysztof

I’m sorry, Krzysztof — I didn’t ignore your comments. I carefully read the suggested documentation regarding docs and DTS submissions.
My mistake was that I simply missed the point about sorting the string list, and I’ve already acknowledged that in my earlier reply.
Apologies for the confusion — it wasn’t intentional or out of disregard on my part.