linux-kernel - Re: [PATCH 01/10] lib/crypto: blake2s: Adjust parameter order of blake2s()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPT3dImhaI6Dpqs7@zx2c4.com>
Date: Sun, 19 Oct 2025 16:36:36 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-btrfs@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH 01/10] lib/crypto: blake2s: Adjust parameter order of
 blake2s()

On Fri, Oct 17, 2025 at 09:30:57PM -0700, Eric Biggers wrote:
> Reorder the parameters of blake2s() from (out, in, key, outlen, inlen,
> keylen) to (key, keylen, in, inlen, out, outlen).

No objections to putting the size next to the argument. That makes
sense. But the order really should be:

    out, outlen, in, inlen, key, keylen

in order to match normal APIs that output data. The output argument goes
first. The input argument goes next. Auxiliary information goes after.