linux-kernel - RE: [PATCH v2] memory: renesas-rpc-if: Add suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB113469022C1D422A8E2F5E33A86F4A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Sun, 19 Oct 2025 18:06:56 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, biju.das.au <biju.das.au@...il.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Geert
 Uytterhoeven <geert+renesas@...der.be>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2] memory: renesas-rpc-if: Add suspend/resume support

Hi Krzysztof Kozlowski,

Thanks for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 10 October 2025 03:49
> Subject: Re: [PATCH v2] memory: renesas-rpc-if: Add suspend/resume support
> 
> On 23/09/2025 17:14, Biju wrote:
> >  	if (rpc->info->type == XSPI_RZ_G3E) {
> > -		struct clk *spi_clk;
> > -
> > -		spi_clk = devm_clk_get_enabled(dev, "spix2");
> > -		if (IS_ERR(spi_clk))
> > -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> > +		rpc->spix2_clk = devm_clk_get_enabled(dev, "spix2");
> > +		if (IS_ERR(rpc->spix2_clk))
> > +			return dev_err_probe(dev, PTR_ERR(rpc->spix2_clk),
> >  					     "cannot get enabled spix2 clk\n");
> >
> > -		spi_clk = devm_clk_get_enabled(dev, "spi");
> > -		if (IS_ERR(spi_clk))
> > -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> > +		rpc->spi_clk = devm_clk_get_enabled(dev, "spi");
> > +		if (IS_ERR(rpc->spi_clk))
> > +			return dev_err_probe(dev, PTR_ERR(rpc->spi_clk),
> >  					     "cannot get enabled spi clk\n");
> >  	}
> >
> > @@ -1063,6 +1063,44 @@ static void rpcif_remove(struct platform_device *pdev)
> >  	platform_device_unregister(rpc->vdev);
> >  }
> >
> > +static int rpcif_suspend(struct device *dev) {
> > +	struct rpcif_priv *rpc = dev_get_drvdata(dev);
> > +
> > +	if (rpc->info->type == XSPI_RZ_G3E) {
> 
> clk are null in other case, so you can simplify it by dropping this if().

OK, will make the clk optional and drop the if().

> 
> > +		clk_disable_unprepare(rpc->spi_clk);
> > +		clk_disable_unprepare(rpc->spix2_clk);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> > +static int rpcif_resume(struct device *dev) {
> > +	struct rpcif_priv *rpc = dev_get_drvdata(dev);
> > +
> > +	if (rpc->info->type == XSPI_RZ_G3E) {
> 
> 
> ... which would save you one indentation here making it a bit more readable.

Agreed.

Cheers,
Biju