linux-kernel - Re: [PATCH v2 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBLGczi3GeaC4aWECV8NS-zqSHgRa-5onynz9fGsZeN8qgysg@mail.gmail.com>
Date: Sun, 19 Oct 2025 22:53:34 +0200
From: Emil Renner Berthing <emil.renner.berthing@...il.com>
To: Aurelien Jarno <aurelien@...el32.net>
Cc: linux-kernel@...r.kernel.org, Lee Jones <lee@...nel.org>, 
	Sebastian Reichel <sre@...nel.org>, Troy Mitchell <troy.mitchell@...ux.spacemit.com>, 
	Yixun Lan <dlan@...too.org>, Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, 
	"open list:RISC-V ARCHITECTURE:Keyword:riscv" <linux-riscv@...ts.infradead.org>, 
	"open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" <spacemit@...ts.linux.dev>, 
	"open list:SYSTEM RESET/SHUTDOWN DRIVERS" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot

On Sun, 19 Oct 2025 at 22:34, Aurelien Jarno <aurelien@...el32.net> wrote:
>
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@...el32.net>
> Acked-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> Tested-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> ---
> v2:
>  - Rebase onto v6.18-rc1
>  - Use dev_err_probe() to simplify the code
>  - Fix indentation of patch 1
>  - Collect Acked-by and Tested-by
>
>  drivers/power/reset/Kconfig              |  9 +++
>  drivers/power/reset/Makefile             |  1 +
>  drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
>  3 files changed, 98 insertions(+)
>  create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 8248895ca9038..063202923d95d 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -283,6 +283,15 @@ config POWER_RESET_KEYSTONE
>         help
>           Reboot support for the KEYSTONE SoCs.
>
> +config POWER_RESET_SPACEMIT_P1
> +       bool "SpacemiT P1 poweroff and reset driver"

The driver code looks to be written to work as a module, but here it
says "bool" not "tristate".

> +       depends on ARCH_SPACEMIT || COMPILE_TEST
> +       select MFD_SPACEMIT_P1
> +       default ARCH_SPACEMIT

If it does work as a module I'd prefer "default m" here.

/Emil