linux-kernel - Re: [PATCH net-next v3 4/7] net: dsa: lantiq_gswip: manually convert remaining uses of read accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251019152545.524ac596@kernel.org>
Date: Sun, 19 Oct 2025 15:25:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Andreas Schirm
 <andreas.schirm@...mens.com>, Lukas Stockmann
 <lukas.stockmann@...mens.com>, Alexander Sverdlin
 <alexander.sverdlin@...mens.com>, Peter Christen
 <peter.christen@...mens.com>, Avinash Jayaraman <ajayaraman@...linear.com>,
 Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>, Juraj
 Povazanec <jpovazanec@...linear.com>, "Fanni (Fang-Yi) Chan"
 <fchan@...linear.com>, "Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
 "Livia M. Rosu" <lrosu@...linear.com>, John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v3 4/7] net: dsa: lantiq_gswip: manually
 convert remaining uses of read accessors

On Sun, 19 Oct 2025 13:48:36 +0100 Daniel Golle wrote:
> +	for (i = 0; i < ARRAY_SIZE(tbl->key); i++) {
> +		err = regmap_read(priv->gswip, GSWIP_PCE_TBL_KEY(i), &tmp);
> +		if (err)
> +			return err;
> +		tbl->key[i] = tmp;
> +	}
> +	for (i = 0; i < ARRAY_SIZE(tbl->val); i++) {
> +		err = regmap_read(priv->gswip, GSWIP_PCE_TBL_VAL(i), &tmp);
> +		if (err)
> +			return err;
> +		tbl->val[i] = tmp;
> +	}
>  
> -	tbl->mask = gswip_switch_r(priv, GSWIP_PCE_TBL_MASK);
> +	err = regmap_read(priv->gswip, GSWIP_PCE_TBL_MASK, &tmp);
> +	if (err)
> +		return err;
>  
> -	crtl = gswip_switch_r(priv, GSWIP_PCE_TBL_CTRL);
> +	tbl->mask = tmp;
> +	err = regmap_read(priv->gswip, GSWIP_PCE_TBL_CTRL, &tmp);
> +	if (err)
> +		return err;

Coccicheck points out we're holding a mutex here, can't return directly.
-- 
pw-bot: cr