linux-kernel - Re: [PATCH v4 07/14] drm/imx: dc: Add DPR channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24f99c46-ca5d-43cc-a2eb-a6e5029e9f86@nxp.com>
Date: Mon, 20 Oct 2025 10:47:27 +0800
From: Liu Ying <victor.liu@....com>
To: Marek Vasut <marek.vasut@...lbox.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Dmitry Baryshkov <lumag@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Frank Li <Frank.Li@....com>
Subject: Re: [PATCH v4 07/14] drm/imx: dc: Add DPR channel support

On 10/16/2025, Marek Vasut wrote:
> On 10/16/25 8:32 AM, Liu Ying wrote:
> 
> Hello Liu,

Hello Marek,

> 
>> +++ b/drivers/gpu/drm/imx/dc/Kconfig
>> @@ -1,6 +1,7 @@
>>   config DRM_IMX8_DC
>>       tristate "Freescale i.MX8 Display Controller Graphics"
>>       depends on DRM && COMMON_CLK && OF && (ARCH_MXC || COMPILE_TEST)
>> +    depends on IMX_SCU
> Can the SCU dependency be made optional,

I don't think this can be done.  If you grep 'depends on IMX_SCU' in
kernel, you may find a handful of existing dependancies.

> or per-module,

Well, DRM_IMX8_DC(for the imx8_dc_drm module) depends on IMX_SCU just as
this patch does.

> or somehow abstracted out (via regmap?),

Like I replied to your i.MX95 DC patch series's cover letter, SCU accesses
registers via Cortex-M core instead of Cortex-A core IIUC.  I really don't
know how to abstract IMX_SCU out, especially via regmap.

> so iMX95 support can be added into the driver easily too ?

Like I replied to your i.MX95 DC patch series, I think i.MX95 DC support
can be in drivers/gpu/drm/imx/dc, but it should be in a separate module
(something like imx95_dc_drm) plus an additional common module(like
imx_dc_drm_common).

-- 
Regards,
Liu Ying