linux-kernel - Re: [PATCH] cifs: Fix TCP_Server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1158747.1760969306@warthog.procyon.org.uk>
Date: Mon, 20 Oct 2025 15:08:26 +0100
From: David Howells <dhowells@...hat.com>
To: Enzo Matsumiya <ematsumiya@...e.de>
Cc: dhowells@...hat.com, Steve French <sfrench@...ba.org>,
    Paulo Alcantara <pc@...guebit.org>, linux-cifs@...r.kernel.org,
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cifs: Fix TCP_Server_Info::credits to be signed

Enzo Matsumiya <ematsumiya@...e.de> wrote:

> Both semantically and technically, credits shouldn't go negative.
> Shouldn't those other fields/functions become unsigned instead?

That's really a question for Steve, but it makes it easier to handle
underflow, and I'm guessing that the maximum credits isn't likely to exceed
2G.

David