[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEnQRZBd1nadLPE0NSWOJLRNwFEnRhOTENv_vestHCLxe41Rbg@mail.gmail.com>
Date: Mon, 20 Oct 2025 17:18:59 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>, Abel Vesa <abelvesa@...nel.org>,
Peng Fan <peng.fan@....com>, Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>, Fabio Estevam <festevam@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>, Daniel Baluta <daniel.baluta@....com>,
Shengjiu Wang <shengjiu.wang@....com>, linux-clk@...r.kernel.org, imx@...ts.linux.dev,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH v2 6/8] reset: imx8mp-audiomix: Extend the driver usage
On Fri, Oct 17, 2025 at 5:57 PM Frank Li <Frank.li@....com> wrote:
>
> On Fri, Oct 17, 2025 at 04:20:23AM -0700, Laurentiu Mihalcea wrote:
> > From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> >
> > Some NXP SoCs integrate one or more, per-subsystem, block control IPs,
> > which allow users to control the assertion and de-assertion of the
> > reset lines tied to some peripherals present in said subsystems. Some
> > examples of such SoCs include i.MX8MP with AUDIOMIX block control and
> > i.MX8ULP with SIM LPAV.
> >
> > Some of the aformentioned block control IPs exhibit a common pattern with
> > respect to the assertion and de-assertion of the reset lines. Namely, the
> > user is able to control the state of the reset line by toggling a bit from
> > one of the IP's registers.
> >
> > Linux can take advantage of this pattern and, instead of having one driver
> > for each block control IP, a single, more generic driver could be used.
> >
> > To allow this to happen, the previous approach, in which a single reset
> > map is used, is replaced by a per-driver approach, in which each auxiliary
> > device driver holds a reference to a certain reset map.
>
> Can you shorter your commit message?, basically, you just add
> imx8mp_reset_info for difference auxiliary_device_id.
It is always preferred to have commit messages trying to explain the context.
I have never heard anyone complaining that the commit message is too long :D.
Daniel.
Powered by blists - more mailing lists