linux-kernel - [PATCH v8 0/2] Improve usage of 'ret' variable and make pcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020030607.10219-1-chiru.cezar.89@gmail.com>
Date: Mon, 20 Oct 2025 06:06:05 +0300
From: Cezar Chiru <chiru.cezar.89@...il.com>
To: andi.shyti@...nel.org,
	wsa+renesas@...g-engineering.com
Cc: linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Cezar Chiru <chiru.cezar.89@...il.com>
Subject: [PATCH v8 0/2] Improve usage of 'ret' variable and make pcf_doAdress() void

Hello maintainers,

This patch series is a response to Change Requests made by Andi Shyti on
[PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch
and more specific on PATCH: i2c: pcf8584: Move 'ret' variable inside for
loop, break if ret < 0.

Change Requests:
 -remove initialization of 'ret' variable inside for loop of pcf_xfer() as
 it is not needed
 -change pcf_doAddress() function type from int to void as it always
 returns 0.

Testing:
  *built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
  top of 6.18.0-rc1.
  *installed kernel and external modules generated by build on my laptop
  *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter.
  *when loading the .ko with i2c_debug parameter an error is seen in dmesg
  and this is expected as the parameter was removed.
  *No success message related to i2c_algo_pcf was seen in dmesg but also
  no failures.
  *Module loading and unloading successful.
  *No PCF8584 Hardware was available.

Cezar Chiru (2):
  i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0.
  i2c: pcf8584: Make pcf_doAddress() function void

 drivers/i2c/algos/i2c-algo-pcf.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

--
2.43.0