linux-kernel - [PATCH net-next] wifi: ath12k: Omit a variable reassignment in ath12k_ahb_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f7c1a504-a449-4497-baf2-dcd69486a3fe@web.de>
Date: Mon, 20 Oct 2025 16:21:29 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
 Jeff Johnson <jjohnson@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: [PATCH net-next] wifi: ath12k: Omit a variable reassignment in
 ath12k_ahb_configure_rproc()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 20 Oct 2025 16:16:34 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/net/wireless/ath/ath12k/ahb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index b30527c402f6..92079de201a2 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -876,8 +876,7 @@ static int ath12k_ahb_configure_rproc(struct ath12k_base *ab)
 
 	ret = ath12k_ahb_register_rproc_notifier(ab);
 	if (ret < 0) {
-		ret = dev_err_probe(&ab->pdev->dev, ret,
-				    "failed to register rproc notifier\n");
+		dev_err_probe(&ab->pdev->dev, ret, "failed to register rproc notifier\n");
 		goto err_put_rproc;
 	}
 
-- 
2.51.1