linux-kernel - [PATCH] platform/surface: aggregator: Omit a variable reassignment in ssam_serial_hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b25c9842-7ebc-43f0-a411-8098359f81a6@web.de>
Date: Mon, 20 Oct 2025 16:43:16 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: platform-driver-x86@...r.kernel.org, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Konrad Dybcio <quic_kdybcio@...cinc.com>,
 Maximilian Luz <luzmaximilian@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: [PATCH] platform/surface: aggregator: Omit a variable reassignment in
 ssam_serial_hub_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 20 Oct 2025 16:34:59 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/platform/surface/aggregator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/surface/aggregator/core.c b/drivers/platform/surface/aggregator/core.c
index c58e1fdd1a5f..c7e05f7bc199 100644
--- a/drivers/platform/surface/aggregator/core.c
+++ b/drivers/platform/surface/aggregator/core.c
@@ -676,7 +676,7 @@ static int ssam_serial_hub_probe(struct serdev_device *serdev)
 
 	status = ssam_serdev_setup(ssh, serdev);
 	if (status) {
-		status = dev_err_probe(dev, status, "failed to setup serdev\n");
+		dev_err_probe(dev, status, "failed to setup serdev\n");
 		goto err_devinit;
 	}
 
-- 
2.51.1