linux-kernel - [PATCH]: USB cx231xx: Remove unused var assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251020150616.994029-1-michaelestner@web.de>
Date: Mon, 20 Oct 2025 17:06:14 +0200
From: Michael Estner <michaelestner@....de>
To: linux-media@...r.kernel.org
Cc: Michael Estner <michaelestner@....de>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...nel.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Colin Ian King <colin.i.king@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH]: USB cx231xx: Remove unused var assignment

* Remove unused variable assignments.
  The status variable has multiple assignments which are overwritten
  before used once. With this patch this unnecessary variable assignments
  get removed.

* I got the issues out of the report from:
  https://scan7.scan.coverity.com/#/project-view/55309/11354
  The exact findings are:
  * Issue=1226885
  * Issue=1226861
  * Issue=1226879
  * Issue=1226878
  * Issue=1226866

Signed-off-by: Michael Estner <michaelestner@....de>
---
 drivers/media/usb/cx231xx/cx231xx-avcore.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
index 1cfec76b72f3..d268d988123e 100644
--- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
+++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
@@ -760,7 +760,6 @@ int cx231xx_set_decoder_video_input(struct cx231xx *dev,
 
 		status = vid_blk_write_word(dev, AFE_CTRL, value);
 
-		status = cx231xx_afe_set_mode(dev, AFE_MODE_BASEBAND);
 		break;
 	case CX231XX_VMUX_TELEVISION:
 	case CX231XX_VMUX_CABLE:
@@ -910,8 +909,6 @@ int cx231xx_set_decoder_video_input(struct cx231xx *dev,
 			if (dev->tuner_type == TUNER_NXP_TDA18271) {
 				status = vid_blk_read_word(dev, PIN_CTRL,
 				 &value);
-				status = vid_blk_write_word(dev, PIN_CTRL,
-				 (value & 0xFFFFFFEF));
 			}
 
 			break;
@@ -1092,7 +1089,6 @@ int cx231xx_set_audio_input(struct cx231xx *dev, u8 input)
 		ainput = AUDIO_INPUT_TUNER_TV;
 		break;
 	case CX231XX_AMUX_LINE_IN:
-		status = cx231xx_i2s_blk_set_audio_input(dev, input);
 		ainput = AUDIO_INPUT_LINE;
 		break;
 	default:
@@ -1865,8 +1861,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
 						0x1befbf06);
 		status = vid_blk_write_word(dev, DIF_SRC_GAIN_CONTROL,
 						0x000035e8);
-		status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
-						0x00000000);
 		/* Save the Spec Inversion value */
 		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;
 		dif_misc_ctrl_value |= 0x3A0A3F10;
@@ -2702,8 +2696,6 @@ int cx231xx_set_gpio_value(struct cx231xx *dev, int pin_number, int pin_value)
 		/* It was in input mode */
 		value = dev->gpio_dir | (1 << pin_number);
 		dev->gpio_dir = value;
-		status = cx231xx_set_gpio_bit(dev, dev->gpio_dir,
-					      dev->gpio_val);
 	}
 
 	if (pin_value == 0)
-- 
2.34.1