linux-kernel - Re: [PATCH] PCI: sg2042: Fix a reference count issue in sg2042_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251020152738.GA1141158@bhelgaas>
Date: Mon, 20 Oct 2025 10:27:38 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Chen Wang <unicorn_wang@...look.com>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: sg2042: Fix a reference count issue in
 sg2042_pcie_remove()

On Mon, Oct 13, 2025 at 10:31:22AM +0800, Chen Wang wrote:
> Hi，Manivannan,
> 
> I see 6.18-rc1 is released. Could you please pick this fix for 6.18-rcX?

Mani queued this for v6.19.  Is there a reason it should be in v6.18
instead?  We're after the v6.18 merge window now, so we only add
things to v6.18 if they fix a serious issue.

> On 9/30/2025 8:43 AM, Chen Wang wrote:
> > 
> > On 9/30/2025 2:13 AM, Christophe JAILLET wrote:
> > > devm_pm_runtime_enable() is used in the probe, so pm_runtime_disable()
> > > should not be called explicitly in the remove function.
> > > 
> > > Fixes: 1c72774df028 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver")
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > 
> > LGTM.
> > 
> > Acked-by: Chen Wang <unicorn_wang@...look.com>
> > 
> > Tested-by: Chen Wang <unicorn_wang@...look.com> # on Pioneerbox.
> > 
> > Thanks,
> > 
> > Chen
> > 
> > > ---
> > > Compile tested only
> > > ---
> > >   drivers/pci/controller/cadence/pcie-sg2042.c | 3 ---
> > >   1 file changed, 3 deletions(-)
> > > 
> > > diff --git a/drivers/pci/controller/cadence/pcie-sg2042.c
> > > b/drivers/pci/controller/cadence/pcie-sg2042.c
> > > index a077b28d4894..0c50c74d03ee 100644
> > > --- a/drivers/pci/controller/cadence/pcie-sg2042.c
> > > +++ b/drivers/pci/controller/cadence/pcie-sg2042.c
> > > @@ -74,15 +74,12 @@ static int sg2042_pcie_probe(struct
> > > platform_device *pdev)
> > >   static void sg2042_pcie_remove(struct platform_device *pdev)
> > >   {
> > >       struct cdns_pcie *pcie = platform_get_drvdata(pdev);
> > > -    struct device *dev = &pdev->dev;
> > >       struct cdns_pcie_rc *rc;
> > >         rc = container_of(pcie, struct cdns_pcie_rc, pcie);
> > >       cdns_pcie_host_disable(rc);
> > >         cdns_pcie_disable_phy(pcie);
> > > -
> > > -    pm_runtime_disable(dev);
> > >   }
> > >     static int sg2042_pcie_suspend_noirq(struct device *dev)