linux-kernel - Re: [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42b9b376-897e-4984-909b-218bd1e3214a@intel.com>
Date: Mon, 20 Oct 2025 17:41:29 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
CC: <ast@...nel.org>, <daniel@...earbox.net>, <davem@...emloft.net>,
	<kuba@...nel.org>, <hawk@...nel.org>, <john.fastabend@...il.com>,
	<sdf@...ichev.me>, <andrii@...nel.org>, <martin.lau@...ux.dev>,
	<eddyz87@...il.com>, <song@...nel.org>, <yonghong.song@...ux.dev>,
	<kpsingh@...nel.org>, <haoluo@...gle.com>, <jolsa@...nel.org>,
	<netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <skhan@...uxfoundation.org>,
	<david.hunter.linux@...il.com>, <khalid@...nel.org>,
	<linux-kernel-mentees@...ts.linuxfoundation.org>
Subject: Re: [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment

From: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
Date: Sun, 19 Oct 2025 17:58:55 +0100

> After discussion with bpf maintainers[1], queue_index could
> be propagated to the remote XDP program by the xdp_md struct[2]

But it's not done automatically, so not aware users may get confused.

Instead of just removing the TODO, I believe you should leave a comment
here that the RxQ index gets lots after the frame is redirected, so if
someone really wants it, he/she should use <what the second link says>.

> which makes this todo a misguide for future effort.
> 
> [1]:https://lore.kernel.org/all/87y0q23j2w.fsf@cloudflare.com/
> [2]:https://docs.ebpf.io/linux/helper-function/bpf_xdp_adjust_meta/
> 
> Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
Thanks,
Olek