linux-kernel - Re: [PATCH net-next] net: ti: icssg-prueth: Omit a variable reassignment in prueth_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6303480e-8e08-4171-9374-75b6183df690@intel.com>
Date: Mon, 20 Oct 2025 17:51:15 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Markus Elfring <Markus.Elfring@....de>
CC: <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, "Andrew
 Lunn" <andrew+netdev@...n.ch>, Byungchul Park <byungchul@...com>, "David S.
 Miller" <davem@...emloft.net>, Diogo Ivo <diogo.ivo@...mens.com>, "Eric
 Dumazet" <edumazet@...gle.com>, Grygorii Strashko <grygorii.strashko@...com>,
	Himanshu Mittal <h-mittal1@...com>, Jakub Kicinski <kuba@...nel.org>, "Jan
 Kiszka" <jan.kiszka@...mens.com>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>, MD Danish Anwar <danishanwar@...com>,
	Meghana Malladi <m-malladi@...com>, Paolo Abeni <pabeni@...hat.com>, "Ravi
 Gunasekaran" <r-gunasekaran@...com>, Roger Quadros <rogerq@...nel.org>,
	"Simon Horman" <horms@...nel.org>, Vignesh Raghavendra <vigneshr@...com>,
	LKML <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>,
	Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next] net: ti: icssg-prueth: Omit a variable
 reassignment in prueth_netdev_init()

From: Markus Elfring <Markus.Elfring@....de>
Date: Mon, 20 Oct 2025 16:02:56 +0200

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 20 Oct 2025 15:46:11 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete two redundant variable reassignments.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c     | 3 +--
>  drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index e42d0fdefee1..0bfd761bffc5 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -1248,8 +1248,7 @@ static int prueth_netdev_init(struct prueth *prueth,
>  	} else if (of_phy_is_fixed_link(eth_node)) {
>  		ret = of_phy_register_fixed_link(eth_node);
>  		if (ret) {
> -			ret = dev_err_probe(prueth->dev, ret,
> -					    "failed to register fixed-link phy\n");
> +			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
>  			goto free;
>  		}
>  
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> index 5e225310c9de..bd88877e8e65 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> @@ -816,8 +816,7 @@ static int prueth_netdev_init(struct prueth *prueth,
>  	} else if (of_phy_is_fixed_link(eth_node)) {
>  		ret = of_phy_register_fixed_link(eth_node);
>  		if (ret) {
> -			ret = dev_err_probe(prueth->dev, ret,
> -					    "failed to register fixed-link phy\n");
> +			dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
>  			goto free;
>  		}

Thanks,
Olek