linux-kernel - Re: [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4979bd26-0a77-4390-9db2-6d40cd7f963c@kernel.org>
Date: Mon, 20 Oct 2025 17:55:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Jishnu Prakash <jishnu.prakash@....qualcomm.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jonathan Cameron <jic23@...nel.org>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, agross@...nel.org, andersson@...nel.org,
 lumag@...nel.org, dmitry.baryshkov@....qualcomm.com, konradybcio@...nel.org,
 daniel.lezcano@...aro.org, sboyd@...nel.org, amitk@...nel.org,
 thara.gopinath@...il.com, lee@...nel.org, rafael@...nel.org,
 subbaraman.narayanamurthy@....qualcomm.com, david.collins@....qualcomm.com,
 anjelique.melendez@....qualcomm.com, kamal.wadhwa@....qualcomm.com,
 rui.zhang@...el.com, lukasz.luba@....com, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 cros-qcom-dts-watchers@...omium.org, quic_kotarake@...cinc.com,
 neil.armstrong@...aro.org, stephan.gerhold@...aro.org,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5
 Gen3 ADC

On 20/10/2025 14:51, Konrad Dybcio wrote:
> On 10/17/25 3:40 PM, Krzysztof Kozlowski wrote:
>> On 17/10/2025 13:18, Jishnu Prakash wrote:
>>> Hi Krzysztof,
>>>
>>> On 10/9/2025 5:22 AM, Krzysztof Kozlowski wrote:
>>>> On 08/10/2025 23:20, Jishnu Prakash wrote:
>>>>> Hi Krzysztof,
>>>>>
>>>>> On 10/4/2025 12:22 PM, Krzysztof Kozlowski wrote:
>>>>>> On Sat, 4 Oct 2025 at 11:42, Jishnu Prakash
>>>>>> <jishnu.prakash@....qualcomm.com> wrote:
>>>>>>>
>>>>>>> Hi Jonathan,
>>>>>>>
>>>>>>> On 9/27/2025 7:17 PM, Jonathan Cameron wrote:
>>>>>>>> On Fri, 19 Sep 2025 20:17:43 +0530
>>>>>>>> Jishnu Prakash <jishnu.prakash@....qualcomm.com> wrote:
> 
> [...]
> 
>>> Can you please provide your suggestions on changes we can make
>>> in the above points ?
>>
>> You just pasted DT. I asked about SW, software. Please read carefully
>> previous comments.
> 
> Is the problem that Jishnu included some indices in dt-bindings without
> also adding them in the driver's adc5_gen3_chans_pmic[] array?
> 
> As in, would the resolution to this thread be simply handling all of
> them in the driver correctly?

The solution is to remove them from the bindings, just like we do with
many other hardware constants. Of course if these are not hardware
constants, but part of ABI, then solution would be different but no one
provided proof or argument that this is any binding. All proofs were
"but I want to use it in my DTS", which proofs nothing. Not a binding.

While this issue is not that important, we keep discussing it because
author does not try to understand the problem or even keep up the
discussion. Instead repeats the same without really reading my
messages... and then disappears for month or more.

Best regards,
Krzysztof