[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6bvfbwfvwtqmou27dnrznhl32ctz2rwb2a3shuelssrtrcchbi@zn24wtni7cub>
Date: Mon, 20 Oct 2025 12:42:31 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Christoph Hellwig <hch@...radead.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-block@...r.kernel.org
Subject: Re: [GIT PULL] block-bio_iov_iter_export
On Mon, Oct 20, 2025 at 07:54:03AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 10:49:57AM -0400, Kent Overstreet wrote:
> > Christoph, I don't know what you're claiming here. I see no tweaks in
> > the original patch, that's all code I wrote.
>
> Then look closer.
>
> > There was no need for you to drop the EXPORT_SYMBOL.
> > What I want to know is, is this going to become a pattern?
>
> Of course there was. The kernel doesn't keep unused code around,
> including symbols. So anything that is unused will eventually be
> garbage collected. There's even folks around that run scripts and
> automate it (David Alan Gilbert is the most active one currently).
A comment would be an easy solution to that.
>
> > I can vendorize this one function, but If you're going to make a habit
> > of ripping out exports and functionality bcachefs depends on, I can't
> > expect I'll always be able to.
>
> I'm not sure why you're turning this personal and singling me out.
> Yes, unused exports and code are removed all the time, and that's a
> feature and not a bug.
If this is a serious question, READ FUA is another answer :)
Powered by blists - more mailing lists