linux-kernel - Re: [PATCH v5 05/10] PM: EM: Add an iterator and accessor for the performance domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hAnKEUP7n_d3bzVEi0HGmgZXC-+U=_RmS1n0wGniv8qQ@mail.gmail.com>
Date: Mon, 20 Oct 2025 19:44:23 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: kernel test robot <lkp@...el.com>, Changwoo Min <changwoo@...lia.com>
Cc: lukasz.luba@....com, rafael@...nel.org, len.brown@...el.com, 
	pavel@...nel.org, oe-kbuild-all@...ts.linux.dev, christian.loehle@....com, 
	tj@...nel.org, kernel-dev@...lia.com, linux-pm@...r.kernel.org, 
	sched-ext@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 05/10] PM: EM: Add an iterator and accessor for the
 performance domain

On Wed, Oct 15, 2025 at 6:50 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Changwoo,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on amd-pstate/linux-next]
> [also build test ERROR on amd-pstate/bleeding-edge linus/master v6.18-rc1 next-20251014]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Changwoo-Min/PM-EM-Assign-a-unique-ID-when-creating-a-performance-domain/20251014-082420
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
> patch link:    https://lore.kernel.org/r/20251014001055.772422-6-changwoo%40igalia.com
> patch subject: [PATCH v5 05/10] PM: EM: Add an iterator and accessor for the performance domain
> config: i386-buildonly-randconfig-001-20251015 (https://download.01.org/0day-ci/archive/20251015/202510151232.UNZ2J7TZ-lkp@intel.com/config)
> compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251015/202510151232.UNZ2J7TZ-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202510151232.UNZ2J7TZ-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> kernel/power/energy_model.c:1003:5: error: redefinition of 'for_each_em_perf_domain'
>     1003 | int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
>          |     ^~~~~~~~~~~~~~~~~~~~~~~
>    In file included from kernel/power/energy_model.c:20:
>    kernel/power/em_netlink.h:18:5: note: previous definition of 'for_each_em_perf_domain' with type 'int(int (*)(struct em_perf_domain *, void *), void *)'
>       18 | int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
>          |     ^~~~~~~~~~~~~~~~~~~~~~~
> >> kernel/power/energy_model.c:1022:24: error: redefinition of 'em_perf_domain_get_by_id'
>     1022 | struct em_perf_domain *em_perf_domain_get_by_id(int id)
>          |                        ^~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/power/em_netlink.h:24:24: note: previous definition of 'em_perf_domain_get_by_id' with type 'struct em_perf_domain *(int)'
>       24 | struct em_perf_domain *em_perf_domain_get_by_id(int id)
>          |                        ^~~~~~~~~~~~~~~~~~~~~~~~
>

Please update the patch to address this report and resend it, thanks!

> vim +/for_each_em_perf_domain +1003 kernel/power/energy_model.c
>
>   1002
> > 1003  int for_each_em_perf_domain(int (*cb)(struct em_perf_domain*, void *),
>   1004                              void *data)
>   1005  {
>   1006          struct em_perf_domain *pd;
>   1007
>   1008          lockdep_assert_not_held(&em_pd_mutex);
>   1009          guard(mutex)(&em_pd_list_mutex);
>   1010
>   1011          list_for_each_entry(pd, &em_pd_list, node) {
>   1012                  int ret;
>   1013
>   1014                  ret = cb(pd, data);
>   1015                  if (ret)
>   1016                          return ret;
>   1017          }
>   1018
>   1019          return 0;
>   1020  }
>   1021
> > 1022  struct em_perf_domain *em_perf_domain_get_by_id(int id)
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki