linux-kernel - Re: [PATCH 3/6] mailbox: pcc: Set txdone_irq/txdone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <685b549a-2119-45a4-8996-89e33f47bc5a@huawei.com>
Date: Mon, 20 Oct 2025 12:02:17 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Sudeep Holla <sudeep.holla@....com>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: Adam Young <admiyo@...amperecomputing.com>, Robbie King
	<robbiek@...ghtlabs.com>, Jassi Brar <jassisinghbrar@...il.com>, "Cristian
 Marussi" <cristian.marussi@....com>
Subject: Re: [PATCH 3/6] mailbox: pcc: Set txdone_irq/txdone_poll based on
 PCCT flags


在 2025/10/17 3:08, Sudeep Holla 写道:
> The PCC controller currently enables txdone via IRQ if the PCCT exposes
> platform capability to generate command completion interrupt, but it
> leaves txdone_poll unchanged. Make the behaviour explicit:
>
>    - If ACPI_PCCT_DOORBELL is present, use txdone_irq and disable polling.
>    - Otherwise, disable txdone_irq and fall back to txdone_poll.
>
> Configure the PCC mailbox to use interrupt-based completion for PCC types
> that signal completion via IRQ using TXDONE_BY_IRQ, and fall back to
> polling for others using TXDONE_BY_POLL.
>
> This ensures the PCC driver uses the appropriate completion mechanism
> according to the PCCT table definition and makes the completion mode
> unambiguous avoiding mixed signalling when the platform lacks a doorbell
> flag set.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
LGTM,
Acked-by: lihuisong@...wei.com
>