linux-kernel - Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cd3e303-6e20-4a84-8c91-cb20c1f209b0@roeck-us.net>
Date: Mon, 20 Oct 2025 11:29:32 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Matti Vaittinen <mazziesaccount@...il.com>
Cc: linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Timothy Pearson <tpearson@...torengineering.com>
Subject: Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct
 timeout-sec length and reference watchdog schema

On 10/20/25 09:52, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.
> ---
>   Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> index 0e06570483ae..adb491bcc8dc 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> @@ -57,8 +57,7 @@ properties:
>         - prstb
>         - intb-only
>   
> -  timeout-sec:
> -    maxItems: 2
> +  timeout-sec: true
>   
>     regulators:
>       $ref: /schemas/regulator/rohm,bd96801-regulator.yaml
> @@ -72,7 +71,10 @@ required:
>     - interrupt-names
>     - regulators
>   
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/watchdog/watchdog.yaml
> +
> +unevaluatedProperties: false
>   
>   examples:
>     - |
>