linux-kernel - Re: [GIT PULL] rv fixes and selftests for v6.18-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251020145327.4eb61f5e@gandalf.local.home>
Date: Mon, 20 Oct 2025 14:53:27 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: linux-kernel@...r.kernel.org, Nam Cao <namcao@...utronix.de>
Subject: Re: [GIT PULL] rv fixes and selftests for v6.18-rc3

On Mon, 20 Oct 2025 14:47:44 +0200
Gabriele Monaco <gmonaco@...hat.com> wrote:

> Steve,
> 
> The following changes since commit 211ddde0823f1442e4ad052a2f30f050145ccada:
> 
>   Linux 6.18-rc2 (2025-10-19 15:19:16 -1000)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/gmonaco/linux.git rv-6.18-rc3
> 
> for you to fetch changes up to d9423638c039a15f7a1720f92c6ed0fddc6fea23:
> 
>   selftests/verification: Add initial RV tests (2025-10-20 12:48:20 +0200)
> 
> ----------------------------------------------------------------
> Summary of changes:
> 
> * Adapt the ftracetest script to be run from a different folder, this
>   uses the already existing OPT_TEST_DIR but extends it further to run
>   independent tests, then add an --rv flag to allow using the script for
>   testing RV (mostly) independently on ftrace.

Is the above a bug fix? It looks like it's something that should be added
during the merge window.

> * A bug causing kernel panic when reading enabled_monitors was reported,
>   change callbacks functions to always use list_head iterators and by
>   doing so, fix the wrong pointer that was leading to the panic.

Looks like a bug fix that should go in now.

> * The rtapp/pagefault monitor relies on the MMU to be present
>   (pagefaults exist) but that was not enforced via kconfig, leading to
>   potential build errors on systems without an MMU. Add that kconfig
>   dependency.

Bug fix.

> * Add basic RV selftests in selftests/verification to validate things
>   like available/enabled monitors and reactors. This could have caught
>   the bug introducing kernel panic solved above. Tests use ftracetest.

Not really a bug fix but tests can usually go in with the fixes to bugs
they now detect. Is this dependent on the first patch?

My question is still on that first change. Can that wait till the merge
window? If so, can you remove it from this pull request?

-- Steve


> 
> ----------------------------------------------------------------
> Gabriele Monaco (2):
>       selftest/ftrace: Generalise ftracetest to use with RV
>       selftests/verification: Add initial RV tests
> 
> Nam Cao (2):
>       rv: Fully convert enabled_monitors to use list_head as iterator
>       rv: Make rtapp/pagefault monitor depends on CONFIG_MMU
> 
>  MAINTAINERS                                        |  1 +
>  kernel/trace/rv/monitors/pagefault/Kconfig         |  1 +
>  kernel/trace/rv/rv.c                               | 12 ++--
>  tools/testing/selftests/ftrace/ftracetest          | 34 +++++++---
>  .../ftrace/test.d/00basic/mount_options.tc         |  2 +-
>  tools/testing/selftests/ftrace/test.d/functions    |  6 +-
>  tools/testing/selftests/verification/.gitignore    |  2 +
>  tools/testing/selftests/verification/Makefile      |  8 +++
>  tools/testing/selftests/verification/config        |  1 +
>  tools/testing/selftests/verification/settings      |  1 +
>  .../selftests/verification/test.d/functions        | 39 +++++++++++
>  .../test.d/rv_monitor_enable_disable.tc            | 75 ++++++++++++++++++++++
>  .../verification/test.d/rv_monitor_reactor.tc      | 68 ++++++++++++++++++++
>  .../verification/test.d/rv_monitors_available.tc   | 18 ++++++
>  .../verification/test.d/rv_wwnr_printk.tc          | 30 +++++++++
>  .../selftests/verification/verificationtest-ktap   |  8 +++
>  16 files changed, 286 insertions(+), 20 deletions(-)
>  create mode 100644 tools/testing/selftests/verification/.gitignore
>  create mode 100644 tools/testing/selftests/verification/Makefile
>  create mode 100644 tools/testing/selftests/verification/config
>  create mode 100644 tools/testing/selftests/verification/settings
>  create mode 100644 tools/testing/selftests/verification/test.d/functions
>  create mode 100644 tools/testing/selftests/verification/test.d/rv_monitor_enable_disable.tc
>  create mode 100644 tools/testing/selftests/verification/test.d/rv_monitor_reactor.tc
>  create mode 100644 tools/testing/selftests/verification/test.d/rv_monitors_available.tc
>  create mode 100644 tools/testing/selftests/verification/test.d/rv_wwnr_printk.tc
>  create mode 100644 tools/testing/selftests/verification/verificationtest-ktap
> 
> Cc: Gabriele Monaco <gmonaco@...hat.com>
> Cc: Nam Cao <namcao@...utronix.de>