linux-kernel - Re: [PATCH] module: Fix device table module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98a11c7b-590b-49e3-99ab-b0857329b0a5@samsung.com>
Date: Mon, 20 Oct 2025 22:40:12 +0200
From: Marek Szyprowski <m.szyprowski@...sung.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>, x86@...nel.org
Cc: linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>, Miroslav
	Benes <mbenes@...e.cz>, Joe Lawrence <joe.lawrence@...hat.com>,
	live-patching@...r.kernel.org, Song Liu <song@...nel.org>, laokz
	<laokz@...mail.com>, Jiri Kosina <jikos@...nel.org>, Marcos Paulo de Souza
	<mpdesouza@...e.com>, Weinan Liu <wnliu@...gle.com>, Fazla Mehrab
	<a.mehrab@...edance.com>, Chen Zhongjin <chenzhongjin@...wei.com>, Puranjay
	Mohan <puranjay@...nel.org>, Dylan Hatch <dylanbhatch@...gle.com>, Peter
	Zijlstra <peterz@...radead.org>, Alexander Stein
	<alexander.stein@...tq-group.com>, Mark Brown <broonie@...nel.org>, Cosmin
	Tanislav <demonsingur@...il.com>
Subject: Re: [PATCH] module: Fix device table module aliases

On 20.10.2025 19:53, Josh Poimboeuf wrote:
> Commit 6717e8f91db7 ("kbuild: Remove 'kmod_' prefix from
> __KBUILD_MODNAME") inadvertently broke module alias generation for
> modules which rely on MODULE_DEVICE_TABLE().
>
> It removed the "kmod_" prefix from __KBUILD_MODNAME, which caused
> MODULE_DEVICE_TABLE() to generate a symbol name which no longer matched
> the format expected by handle_moddevtable() in scripts/mod/file2alias.c.
>
> As a result, modpost failed to find the device tables, leading to
> missing module aliases.
>
> Fix this by explicitly adding the "kmod_" string within the
> MODULE_DEVICE_TABLE() macro itself, restoring the symbol name to the
> format expected by file2alias.c.
>
> Fixes: 6717e8f91db7 ("kbuild: Remove 'kmod_' prefix from __KBUILD_MODNAME")
> Reported-by: Alexander Stein <alexander.stein@...tq-group.com>
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Reported-by: Mark Brown <broonie@...nel.org>
> Reported-by: Cosmin Tanislav <demonsingur@...il.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>

This fixes the issue observed on my test systems. Thanks!

Closes: 
https://lore.kernel.org/all/d7b49971-8d77-43e2-b0cd-a70c6463ea57@samsung.com/
Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>


> ---
>   include/linux/module.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index e135cc79aceea..d80c3ea574726 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -251,10 +251,11 @@ struct module_kobject *lookup_or_create_module_kobject(const char *name);
>    */
>   #define __mod_device_table(type, name)	\
>   	__PASTE(__mod_device_table__,	\
> +	__PASTE(kmod_,			\
>   	__PASTE(__KBUILD_MODNAME,	\
>   	__PASTE(__,			\
>   	__PASTE(type,			\
> -	__PASTE(__, name)))))
> +	__PASTE(__, name))))))
>   
>   /* Creates an alias so file2alias.c can find device table. */
>   #define MODULE_DEVICE_TABLE(type, name)					\

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland