linux-kernel - Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251020230158.GF316284@nvidia.com>
Date: Mon, 20 Oct 2025 20:01:58 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, shuah@...nel.org, alessandro.zanni87@...il.com,
	iommu@...ts.linux.dev, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in
 _test_cmd_trigger_vevents()

On Tue, Oct 14, 2025 at 02:48:46PM -0700, Nicolin Chen wrote:
> The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> 
> Drop the '!' to fix it.
> 
> Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  tools/testing/selftests/iommu/iommufd_utils.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason