| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<TY3PR01MB99823396DFFF60DCF661011192F5A@TY3PR01MB9982.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 06:11:52 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <Frank.li@....com>
CC: <nobuhiro.iwamatsu.x90@...l.toshiba>, <mchehab@...nel.org>,
<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<p.zabel@...gutronix.de>, <linux-media@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
Toshiba Visconti MIPI CSI-2 Receiver
Hello Frank
Thank you for review comments.
> -----Original Message-----
> From: Frank Li <Frank.li@....com>
> Sent: Thursday, October 16, 2025 1:35 PM
> To: ishikawa yuji(石川 悠司 □ＡＩＤＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>
> Cc: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Philipp Zabel
> <p.zabel@...gutronix.de>; linux-media@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
> Toshiba Visconti MIPI CSI-2 Receiver
>
> On Thu, Oct 16, 2025 at 11:24:38AM +0900, Yuji Ishikawa wrote:
> > Adds the Device Tree binding documentation that allows to describe the
> > MIPI CSI-2 Receiver found in Toshiba Visconti SoCs.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > ---
> > Changelog v12:
> > - Newly add bindings for CSI2RX driver
> >
> > Changelog v13:
> > - add entries to MAINTAINERS file.
> > - update email address of Nobuhiro Iwamatsu in /maintainers
> > - add Yuji Ishikawa to /maintainers
> > - change /properties/compatible: toshiba,visconti5-csi2rx ->
> > toshiba,visconti5-csi2
> > - change bindings file name: toshiba,visconti5-csi2rx ->
> > toshiba,visconti5-csi2
> > - change node name in sample DTS: csi2rx -> csi
> > - remove "|-" from /description
> > - update /description
> > - add definitions of clock and reset
> > - update /properties/ports/properties/port@...escription for better
> > comment
> > - update /properties/ports/properties/port@...ref to specify full
> > pathname
> > - remove
> /properties/ports/properties/port@...roperties/endpoint/properties/data-la
> nes/description because the default text provides enough information.
> > - update sample dts
> > ---
> > .../bindings/media/toshiba,visconti5-csi2.yaml | 125
> +++++++++++++++++++++
> > MAINTAINERS | 7 ++
> > 2 files changed, 132 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.yaml
> > b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.yaml
> > new file mode 100644
> > index 000000000000..21fb46de5b6e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.y
> > +++ aml
> > @@ -0,0 +1,125 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/toshiba,visconti5-csi2.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver
> > +
> > +maintainers:
> > + - Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>
> > + - Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > +
> > +description:
> > + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI
> > +CSI-2 video
> > + stream. The obtained video stream is used as input for the Visconti5 VIIF.
> > +
> > +properties:
> > + compatible:
> > + const: toshiba,visconti5-csi2
> > +
>
> ...
>
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + csi0: csi@...08000 {
>
> Needn't label csi0
>
I'll drop the label.
> > + compatible = "toshiba,visconti5-csi2";
> > + reg = <0 0x1c008000 0 0x400>;
> > + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&pismu TMPV770X_CLK_VIIFBS0_CFG>,
> > + <&pismu TMPV770X_CLK_VIIFBS0_APB>;
> > + clock-names = "cfg", "apb";
> > + resets = <&pismu TMPV770X_RESET_VIIFBS0_APB>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> need empty line here.
I'll add empty line before blocks.
> > + port@0 {
> > + reg = <0>;
>
> empty line here
>
> > + csi0_in: endpoint {
> > + data-lanes = <1 2>;
> > + remote-endpoint = <&imx219_out>;
> > + };
> > + };
>
> empty line here
>
> Frank
> > + port@1 {
> > + reg = <1>;
> > + csi0_out: endpoint {
> > + remote-endpoint = <&video0_in>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 46126ce2f968..e4634a0aad74 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -25979,6 +25979,13 @@ F:
> Documentation/devicetree/bindings/media/i2c/toshiba,tc358743.txt
> > F: drivers/media/i2c/tc358743*
> > F: include/media/i2c/tc358743.h
> >
> > +TOSHIBA VISCONTI VIIF DRIVER
> > +M: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>
> > +M: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > +L: linux-media@...r.kernel.org
> > +S: Maintained
> > +F:
> Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.ya
> ml
> > +
> > TOSHIBA WMI HOTKEYS DRIVER
> > M: Azael Avalos <coproscefalo@...il.com>
> > L: platform-driver-x86@...r.kernel.org
> >
> > --
> > 2.34.1
> >
> >
Regards,
Yuji Ishikawa
Powered by blists - more mailing lists