linux-kernel - RE: [PATCH v2] ufs: core: Initialize a value of an attribute as returned by uic cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <323701dc4189$75c2fbf0$6148f3d0$@samsung.com>
Date: Mon, 20 Oct 2025 15:19:15 +0900
From: "Wonkon Kim" <wkon.kim@...sung.com>
To: "'Bart Van Assche'" <bvanassche@....org>,
	<James.Bottomley@...senPartnership.com>, <martin.petersen@...cle.com>,
	<peter.wang@...iatek.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] ufs: core: Initialize a value of an attribute as
 returned by uic cmd

> On 10/13/25 9:40 PM, Wonkon Kim wrote:
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 9a43102b2b21..6858f005cc8b 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -4273,8 +4273,8 @@ int ufshcd_dme_get_attr(struct ufs_hba *hba, u32
> attr_sel,
> >   			get, UIC_GET_ATTR_ID(attr_sel),
> >   			UFS_UIC_COMMAND_RETRIES - retries);
> >
> > -	if (mib_val && !ret)
> > -		*mib_val = uic_cmd.argument3;
> > +	if (mib_val)
> > +		*mib_val = ret == 0 ? uic_cmd.argument3 : 0;
> >
> >   	if (peer && (hba->quirks & UFSHCD_QUIRK_DME_PEER_ACCESS_AUTO_MODE)
> >   	    && pwr_mode_change)
> > @@ -4990,7 +4990,7 @@ EXPORT_SYMBOL_GPL(ufshcd_hba_enable);
> >
> >   static int ufshcd_disable_tx_lcc(struct ufs_hba *hba, bool peer)
> >   {
> > -	int tx_lanes = 0, i, err = 0;
> > +	int tx_lanes, i, err = 0;
> >
> >   	if (!peer)
> >   		ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDTXDATALANES),
> 
> Please split this patch into two patches: a first patch with the
> ufshcd_dme_get_attr() change and a second patch with the
> ufshcd_disable_tx_lcc() change. Please also add a Fixes: tag to the first
> patch. That will cause the first patch to be included automatically in
> stable kernels and also in Android kernels.
> 
> Thanks,
> 
> Bart.


Sure. I'll split and update it.

Thanks,
Wonkon Kim.