linux-kernel - RE: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <TY3PR01MB9982C8570878DFAB956A1B4192F5A@TY3PR01MB9982.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 06:16:04 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <krzk@...nel.org>, <nobuhiro.iwamatsu.x90@...l.toshiba>,
        <mchehab@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <p.zabel@...gutronix.de>
CC: <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
 Toshiba Visconti MIPI CSI-2 Receiver

Hello Krzysztof

Thank you for review comments.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, October 16, 2025 3:38 PM
> To: ishikawa yuji(石川 悠司 □ＡＩＤＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○
> ＣＰＴ) <nobuhiro.iwamatsu.x90@...l.toshiba>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Philipp Zabel
> <p.zabel@...gutronix.de>
> Cc: linux-media@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add
> Toshiba Visconti MIPI CSI-2 Receiver
> 
> On 16/10/2025 04:24, Yuji Ishikawa wrote:
> > Adds the Device Tree binding documentation that allows to describe
> 
> "Add".
> 
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submit
> ting-patches.rst#L94
> 

I'll fix commit messages.

> 
> > the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs.
> 
> 
> ...
> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        csi0: csi@...08000 {
> 
> I don't understand why the label appeared. It is not used and it wasn't here
> before. I did not ask to add label, but I only asked to fix the node name to match
> generic names rule.
> 
> Drop the label. With these fixes:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 

I'll remove the label.

> 
> Best regards,
> Krzysztof

Regards,
Yuji Ishikawa