[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251020010050-GYD1506524@gentoo.org>
Date: Mon, 20 Oct 2025 09:00:50 +0800
From: Yixun Lan <dlan@...too.org>
To: michael.opdenacker@...tcommit.com
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <pjw@...nel.org>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] riscv: dts: spacemit: add Ethernet and PDMA to
OrangePi RV2
Hi Michael,
On 10:02 Fri 17 Oct , michael.opdenacker@...tcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
>
> Aligning with k1-bananapi-f3.dts
>
The DTS change looks good, but the commit message is kind of obscure
and unclear, I'd like to have an explict brief description for what
have done in the patch, without people looking at the actual DT code,
although in this case the title already says about it, but we could
still give slightly more info/context:
The OrangePi RV2 board ships two RGMII ethernet ports with each
has an external Motorcomm YT8531C PHY attached, the PHY use gpio
for the reset pin control.
Enable PDMA for OrangePi RV2 board which provided by SpacemiT K1-based SoC.
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tcommit.com>
--
Yixun Lan (dlan)
Powered by blists - more mailing lists