linux-kernel - Re: [PATCH v3 2/2] perf tools annotate: Align the symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03d24c35-f56a-466f-8af0-aa70ffc838f3@intel.com>
Date: Mon, 20 Oct 2025 14:33:21 +0800
From: "Li, Tianyou" <tianyou.li@...el.com>
To: Namhyung Kim <namhyung@...nel.org>
CC: James Clark <james.clark@...aro.org>, Peter Zijlstra
	<peterz@...radead.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, "Mark
 Rutland" <mark.rutland@....com>, Alexander Shishkin
	<alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, "Ian
 Rogers" <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, "Kan
 Liang" <kan.liang@...ux.intel.com>, Ravi Bangoria <ravi.bangoria@....com>,
	<wangyang.guo@...el.com>, <pan.deng@...el.com>, <zhiguo.zhou@...el.com>,
	<jiebin.sun@...el.com>, <thomas.falcon@...el.com>, <dapeng1.mi@...el.com>,
	<linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] perf tools annotate: Align the symbol_annotate
 return code

Hi Namhyung,


On 10/20/2025 12:11 PM, Namhyung Kim wrote:
> On Mon, Oct 20, 2025 at 10:14:34AM +0800, Tianyou Li wrote:
>> Return error code from the symbol_annotate previously checks the
>> evsel__get_arch from '<0', now to '!=0'.
>>
>> Suggested-by: James Clark <james.clark@...aro.org>
>> Tested-by: Namhyung Kim <namhyung@...nel.org>
> This 'Tested-by' tag belongs to the patch 1 instead of this.  And you
> can add my ack here.
>
> Acked-by: Namhyung Kim <namhyung@...nel.org>
>
> Thanks,
> Namhyung
>

Thanks Namhyung, will send the patch v4 soon. Thanks.


>> Signed-off-by: Tianyou Li <tianyou.li@...el.com>
>> ---
>>   tools/perf/util/annotate.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
>> index 39d6594850f1..859e802a1e5e 100644
>> --- a/tools/perf/util/annotate.c
>> +++ b/tools/perf/util/annotate.c
>> @@ -1021,7 +1021,7 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
>>   	int err, nr;
>>   
>>   	err = evsel__get_arch(evsel, &arch);
>> -	if (err < 0)
>> +	if (err)
>>   		return err;
>>   
>>   	if (parch)
>> -- 
>> 2.47.1
>>