linux-kernel - RE: [PATCH 1/2] dt-bindings: clock: Update identifiers for VIIF on Toshiba Visconti TMPV770x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <TY3PR01MB9982013052EF296EB7C48B9692F5A@TY3PR01MB9982.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 06:19:11 +0000
From: <yuji2.ishikawa@...hiba.co.jp>
To: <krzk@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <nobuhiro.iwamatsu.x90@...l.toshiba>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <p.zabel@...gutronix.de>
CC: <linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: clock: Update identifiers for VIIF on
 Toshiba Visconti TMPV770x SoC

Hello Krzysztof

Thank you for review comments.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, October 16, 2025 3:41 PM
> To: ishikawa yuji(石川 悠司 □ＡＩＤＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; Michael Turquette
> <mturquette@...libre.com>; Stephen Boyd <sboyd@...nel.org>; iwamatsu
> nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Philipp Zabel <p.zabel@...gutronix.de>
> Cc: linux-clk@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: clock: Update identifiers for VIIF on
> Toshiba Visconti TMPV770x SoC
> 
> On 16/10/2025 03:33, Yuji Ishikawa wrote:
> > Update identifiers for the clocks and the resets of Video Input
> > Interface in order to reflect the actual architecture of TMPV770x SoC.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > ---
> >  include/dt-bindings/clock/toshiba,tmpv770x.h | 33
> > +++++++++++++-------  include/dt-bindings/reset/toshiba,tmpv770x.h
> |
> > 10 +++++-
> >  2 files changed, 31 insertions(+), 12 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/toshiba,tmpv770x.h
> > b/include/dt-bindings/clock/toshiba,tmpv770x.h
> > index 5fce713001..2dbd5885c0 100644
> > --- a/include/dt-bindings/clock/toshiba,tmpv770x.h
> > +++ b/include/dt-bindings/clock/toshiba,tmpv770x.h
> > @@ -94,10 +94,10 @@
> >  #define TMPV770X_CLK_DSP2_PBCLK		77
> >  #define TMPV770X_CLK_DSP3_PBCLK		78
> >  #define TMPV770X_CLK_DSVIIF0_APBCLK	79
> > -#define TMPV770X_CLK_VIIF0_APBCLK	80
> > -#define TMPV770X_CLK_VIIF0_CFGCLK	81
> > -#define TMPV770X_CLK_VIIF1_APBCLK	82
> > -#define TMPV770X_CLK_VIIF1_CFGCLK	83
> > +#define TMPV770X_CLK_VIIFBS0_APB	80
> 
> Nope, that's ABI break. These values do not reflect actual architecture, that's
> some non-sense. These are abstract numbers.
> 
> NAK
> 
> 
> 
> Best regards,
> Krzysztof

I'll rewrite the patch not to break ABI.
Existing constant names and values should not be changed.

Regards,
Yuji Ishikawa