linux-kernel - Re: [PATCH v2] firmware: qcom: tzmem: fix qcom_tzmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2f1b46c-1c1f-427b-879c-7fa0bbb783c3@oss.qualcomm.com>
Date: Mon, 20 Oct 2025 09:55:06 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2] firmware: qcom: tzmem: fix qcom_tzmem_policy
 kernel-doc

On 10/17/25 9:13 PM, Randy Dunlap wrote:
> Fix kernel-doc warnings by using correct kernel-doc syntax and
> formatting to prevent warnings:
> 
> Warning: include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>  'QCOM_TZMEM_POLICY_STATIC' not described in enum 'qcom_tzmem_policy'
> Warning: ../include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>  'QCOM_TZMEM_POLICY_MULTIPLIER' not described in enum 'qcom_tzmem_policy'
> Warning: ../include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>  'QCOM_TZMEM_POLICY_ON_DEMAND' not described in enum 'qcom_tzmem_policy'
> 
> Fixes: 84f5a7b67b61 ("firmware: qcom: add a dedicated TrustZone buffer allocator")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> v2: drop "area:" from Subject.
>     Fix kernel-doc comments to have the ending "*/" on a separate line
>     by itself. Otherwise scripts/kernel-doc becomes confused and skips
>     the enum and the following struct!

this is fun!

> 
> Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Cc: Bjorn Andersson <andersson@...nel.org>
> Cc: Konrad Dybcio <konradybcio@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org
> ---
>  include/linux/firmware/qcom/qcom_tzmem.h |   15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> --- linux-next-20251016.orig/include/linux/firmware/qcom/qcom_tzmem.h
> +++ linux-next-20251016/include/linux/firmware/qcom/qcom_tzmem.h
> @@ -17,11 +17,20 @@ struct qcom_tzmem_pool;
>   * enum qcom_tzmem_policy - Policy for pool growth.
>   */
>  enum qcom_tzmem_policy {
> -	/**< Static pool, never grow above initial size. */
> +	/**
> +	 * @QCOM_TZMEM_POLICY_STATIC: Static pool,
> +	 * never grow above initial size.
> +	 */
>  	QCOM_TZMEM_POLICY_STATIC = 1,
> -	/**< When out of memory, add increment * current size of memory. */
> +	/**
> +	 * @QCOM_TZMEM_POLICY_MULTIPLIER: When out of memory,
> +	 * add increment * current size of memory.
> +	 */
>  	QCOM_TZMEM_POLICY_MULTIPLIER,
> -	/**< When out of memory add as much as is needed until max_size. */
> +	/**
> +	 * @QCOM_TZMEM_POLICY_ON_DEMAND: When out of memory
> +	 * add as much as is needed until max_size.
> +	 */
>  	QCOM_TZMEM_POLICY_ON_DEMAND,

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad