linux-kernel - Re: [PATCH] media: renesas: fdp1: Use %pe format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176094702701.935713.13430509417971695210@ping.linuxembedded.co.uk>
Date: Mon, 20 Oct 2025 08:57:07 +0100
From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Ricardo Ribalda <ribalda@...omium.org>
Cc: linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH] media: renesas: fdp1: Use %pe format specifier

Quoting Ricardo Ribalda (2025-10-20 08:53:41)
> The %pe format specifier is designed to print error pointers. It prints
> a symbolic error name (eg. -EINVAL) and it makes the code simpler by
> omitting PTR_ERR()
> 
> This patch fixes this cocci report:
> ./platform/renesas/rcar_fdp1.c:2303:4-11: WARNING: Consider using %pe to print PTR_ERR()
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Thanks, same as the others:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> ---
> It seems that we missed this file from the original patchset.
> https://lore.kernel.org/linux-media/20251013-ptr_err-v1-0-2c5efbd82952@chromium.org/
> ---
>  drivers/media/platform/renesas/rcar_fdp1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
> index 3515601030eccefe3d979303893c93c85ab0a9b2..672869815f636de25ce08261bf327f156b617a37 100644
> --- a/drivers/media/platform/renesas/rcar_fdp1.c
> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
> @@ -2299,8 +2299,7 @@ static int fdp1_probe(struct platform_device *pdev)
>                 fdp1->fcp = rcar_fcp_get(fcp_node);
>                 of_node_put(fcp_node);
>                 if (IS_ERR(fdp1->fcp)) {
> -                       dev_dbg(&pdev->dev, "FCP not found (%ld)\n",
> -                               PTR_ERR(fdp1->fcp));
> +                       dev_dbg(&pdev->dev, "FCP not found (%pe)\n", fdp1->fcp);
>                         return PTR_ERR(fdp1->fcp);
>                 }
>         }
> 
> ---
> base-commit: 8652359fc004cbadbf0e95692c1472caac6260c2
> change-id: 20251020-ptr_err-leftover-1997b3a6e06e
> 
> Best regards,
> -- 
> Ricardo Ribalda <ribalda@...omium.org>
>