linux-kernel - RE: [PATCH 5/6] arm64: dts: renesas: r9a09g057: Add RTC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY7PR01MB14910BB6AD621CC7BA42D56D4D3F5A@TY7PR01MB14910.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 08:13:05 +0000
From: Ovidiu Panait <ovidiu.panait.rb@...esas.com>
To: Biju Das <biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "alexandre.belloni@...tlin.com"
	<alexandre.belloni@...tlin.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "geert+renesas@...der.be" <geert+renesas@...der.be>,
	magnus.damm <magnus.damm@...il.com>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
CC: "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: RE: [PATCH 5/6] arm64: dts: renesas: r9a09g057: Add RTC node

Hi Biju,

> -----Original Message-----
> From: Biju Das <biju.das.jz@...renesas.com>
> Sent: Sunday, October 19, 2025 1:16 PM
> To: Ovidiu Panait <ovidiu.panait.rb@...esas.com>; Claudiu Beznea
> <claudiu.beznea.uj@...renesas.com>; alexandre.belloni@...tlin.com;
> robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> geert+renesas@...der.be; magnus.damm <magnus.damm@...il.com>;
> mturquette@...libre.com; sboyd@...nel.org; p.zabel@...gutronix.de
> Cc: linux-rtc@...r.kernel.org; linux-renesas-soc@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> clk@...r.kernel.org
> Subject: RE: [PATCH 5/6] arm64: dts: renesas: r9a09g057: Add RTC node
> 
> 
> 
> > -----Original Message-----
> > From: Ovidiu Panait <ovidiu.panait.rb@...esas.com>
> > Sent: 19 October 2025 10:21
> > Subject: [PATCH 5/6] arm64: dts: renesas: r9a09g057: Add RTC node
> >
> > Add RTC node to Renesas RZ/V2H ("R9A09G057") SoC DTSI.
> >
> > Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@...esas.com>
> > ---
> >  arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > index 40b15f1db930..e426b9978e22 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> > @@ -591,6 +591,20 @@ wdt3: watchdog@...00400 {
> >  			status = "disabled";
> >  		};
> >
> > +		rtc: rtc@...00800 {
> > +			compatible = "renesas,r9a09g057-rtca3", "renesas,rz-
> rtca3";
> > +			reg = <0 0x11c00800 0 0x400>;
> > +			interrupts = <GIC_SPI 524 IRQ_TYPE_EDGE_RISING>,
> > +				     <GIC_SPI 525 IRQ_TYPE_EDGE_RISING>,
> > +				     <GIC_SPI 526 IRQ_TYPE_EDGE_RISING>;
> > +			interrupt-names = "alarm", "period", "carry";
> > +			clocks = <&cpg CPG_MOD 0x53>, <&rtxin_clk>;
> > +			clock-names = "bus", "counter";
> > +			power-domains = <&cpg>;
> > +			resets = <&cpg 0x79>, <&cpg 0x7a>;
> 
> Missing reset-names??
> 

The resets are retrieved using devm_reset_control_array_get_shared(),
which does not rely on named reset entries. This keeps the
implementation minimal and keeps it in sync with RZ/G3S, which also
does not take the RTC reset by its name.

For this reason, I kept the rtca3 bindings without a reset-names property.

Best regards,
Ovidiu

> Cheers,
> Biju
> 
> > +			status = "disabled";
> > +		};
> > +
> >  		scif: serial@...01400 {
> >  			compatible = "renesas,scif-r9a09g057";
> >  			reg = <0 0x11c01400 0 0x400>;
> > --
> > 2.51.0
> >