linux-kernel - Re: [PATCH v6 4/6] clk: samsung: add Exynos ACPM clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f8da425-63d9-4321-9cd3-976bbd29a52f@kernel.org>
Date: Mon, 20 Oct 2025 10:22:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Peter Griffin <peter.griffin@...aro.org>,
 André Draszik <andre.draszik@...aro.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-clk@...r.kernel.org, willmcvicker@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH v6 4/6] clk: samsung: add Exynos ACPM clock driver

On 20/10/2025 09:45, Tudor Ambarus wrote:
> 
> 
> On 10/20/25 7:54 AM, Krzysztof Kozlowski wrote:
>>> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
>>> index 76a494e95027af26272e30876a87ac293bd56dfa..70a8b82a0136b4d0213d8ff95e029c52436e5c7f 100644
>>> --- a/drivers/clk/samsung/Kconfig
>>> +++ b/drivers/clk/samsung/Kconfig
>>> @@ -95,6 +95,16 @@ config EXYNOS_CLKOUT
>>>  	  status of the certains clocks from SoC, but it could also be tied to
>>>  	  other devices as an input clock.
>>>  
>>> +config EXYNOS_ACPM_CLK
>>> +	tristate "Clock driver controlled via ACPM interface"
>>> +	depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL)
>>
>> I merged the patches but I don't get why we are not enabling it by
>> default, just like every other clock driver. What is so special here?
> 
> Thanks! Are you referring to the depends on line? I needed it otherwise
> on randconfigs where COMPILE_TEST=y and EXYNOS_ACPM_PROTOCOL=n I get:


No. I am referring to missing default and defconfig patch.



Best regards,
Krzysztof