linux-kernel - [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020084429.230322-1-changwoo@igalia.com>
Date: Mon, 20 Oct 2025 17:44:28 +0900
From: Changwoo Min <changwoo@...lia.com>
To: lukasz.luba@....com,
	rafael@...nel.org,
	len.brown@...el.com,
	pavel@...nel.org
Cc: christian.loehle@....com,
	tj@...nel.org,
	kernel-dev@...lia.com,
	linux-pm@...r.kernel.org,
	sched-ext@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Changwoo Min <changwoo@...lia.com>,
	kernel test robot <lkp@...el.com>
Subject: [PATCH 1/2] PM: EM: Remove an unused variable in em_notify_pd_deleted()

The variable `ret` in em_notify_pd_deleted() is set but not used, so
that it causes the following warning:

>> kernel/power/em_netlink.c:228:6: warning: variable 'ret' set but
   not used [-Wunused-but-set-variable]

So, let's remove the unused `ret` to avoid the warning.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510151223.THlBK6QR-lkp@intel.com/
Signed-off-by: Changwoo Min <changwoo@...lia.com>
---
 kernel/power/em_netlink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/power/em_netlink.c b/kernel/power/em_netlink.c
index 2c55c758de6b..48752189a07b 100644
--- a/kernel/power/em_netlink.c
+++ b/kernel/power/em_netlink.c
@@ -269,7 +269,6 @@ static int __em_notify_pd_deleted_size(const struct em_perf_domain *pd)
 void em_notify_pd_deleted(const struct em_perf_domain *pd)
 {
 	struct sk_buff *msg;
-	int ret = -EMSGSIZE;
 	void *hdr;
 	int msg_sz;
 
@@ -287,7 +286,6 @@ void em_notify_pd_deleted(const struct em_perf_domain *pd)
 		goto out_free_msg;
 
 	if (nla_put_u32(msg, EM_A_PD_TABLE_PD_ID, pd->id)) {
-		ret = -EMSGSIZE;
 		goto out_free_msg;
 	}
 
-- 
2.51.1.dirty