linux-kernel - Re: [PATCH mt76 v3] wifi: mt76: Fix DTS power-limits on little endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2453774.NG923GbCHz@ripper>
Date: Mon, 20 Oct 2025 11:30:37 +0200
From: Sven Eckelmann <se@...onwunderlich.de>
To: Felix Fietkau <nbd@....name>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Ryder Lee <ryder.lee@...iatek.com>, Shayne Chen <shayne.chen@...iatek.com>,
 Sean Wang <sean.wang@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 stable@...r.kernel.org
Subject:
 Re: [PATCH mt76 v3] wifi: mt76: Fix DTS power-limits on little endian systems

On Monday, 20 October 2025 11:20:53 CEST Sven Eckelmann (Plasma Cloud) wrote:
> The power-limits for ru and mcs and stored in the devicetree as bytewise
> array (often with sizes which are not a multiple of 4). These arrays have a
> prefix which defines for how many modes a line is applied. This prefix is
> also only a byte - but the code still tried to fix the endianness of this
> byte with a be32 operation. As result, loading was mostly failing or was
> sending completely unexpected values to the firmware.
> 
> Since the other rates are also stored in the devicetree as bytewise arrays,
> just drop the u32 access + be32_to_cpu conversion and directly access them
> as bytes arrays.
> 
> Cc: stable@...r.kernel.org
> Fixes: 22b980badc0f ("mt76: add functions for parsing rate power limits from DT")
> Fixes: a9627d992b5e ("mt76: extend DT rate power limits to support 11ax devices")
> Signed-off-by: Sven Eckelmann (Plasma Cloud) <se@...onwunderlich.de>
> ---
> Changes in v3:
> - add "mt76" as addition prefix after "PATCH" as requested by Zhi-Jun You
> - Link to v2: https://lore.kernel.org/r/20250926-fix-power-limits-v2-1-c2bc7881eb6d@simonwunderlich.de

Seems like the v2 was already picked up [1] and I've simply missed it.

Sorry about the noise,
	Sven

[1] https://github.com/nbd168/wireless/commit/3d63b5084c50607fff84d17d2727c3bab8190d8e

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)