linux-kernel - Re: [GIT PULL] block-bio_iov_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPYCbIrvAkOf5L3g@infradead.org>
Date: Mon, 20 Oct 2025 02:35:40 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Christoph Hellwig <hch@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-block@...r.kernel.org
Subject: Re: [GIT PULL] block-bio_iov_iter_export

On Fri, Oct 17, 2025 at 09:31:59AM -0400, Kent Overstreet wrote:
> On Thu, Oct 16, 2025 at 11:13:46PM -0700, Christoph Hellwig wrote:
> > Umm,
> > 
> > besides adding exports without in-tree users, this is a patch that's
> > never seen any relevant mailing list, in a pull request that the
> > maintainer hasn't seen.  That's now exactly how Linux development works,
> > does it?
> 
> Christoph, I wrote that code /for bcachefs/; the rest of you decided it
> was nice and started using it too.

In fact this version was written by me, giving you the attribution
because I stole a cool idea from you.  But none of this actually
matters, there's not magic exception just because someone wrote the
code.

> Then you removed the export talking about the "abuse" of bcachefs using
> it. WTF?

The random NULL bdev check that breaks the proper splitting.  We told
told you that's not the way to go, but you just sent it directly to Linus
instead of reworking it.  And this then got into the way of the rework
Keith did to support arbitrarily small memory alignments.  Fortunately
we could clean this up properly now.