linux-kernel - Re: [PATCH v4 2/2] media: i2c: add Himax HM1246 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPYHzaBtClxT32r5@ashevche-desk.local>
Date: Mon, 20 Oct 2025 12:58:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Matthias Fend <matthias.fend@...end.at>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Hans Verkuil <hverkuil@...nel.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Hans de Goede <hansg@...nel.org>,
	Ricardo Ribalda <ribalda@...omium.org>,
	André Apitzsch <git@...tzsch.eu>,
	Tarang Raval <tarang.raval@...iconsignals.io>,
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Dongcheng Yan <dongcheng.yan@...el.com>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Jingjing Xiong <jingjing.xiong@...el.com>,
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
	Mehdi Djait <mehdi.djait@...ux.intel.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Hao Yao <hao.yao@...el.com>,
	bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH v4 2/2] media: i2c: add Himax HM1246 image sensor driver

On Mon, Oct 20, 2025 at 09:21:10AM +0200, Matthias Fend wrote:
> Am 18.10.2025 um 22:30 schrieb Andy Shevchenko:
> > On Fri, Oct 17, 2025 at 12:49:39PM +0200, Matthias Fend wrote:

...

> > > +	hm1246->reset_gpio =
> > > +		devm_gpiod_get_optional(hm1246->dev, "reset", GPIOD_OUT_HIGH);
> > > +	if (IS_ERR(hm1246->reset_gpio))
> > > +		return dev_err_probe(hm1246->dev, PTR_ERR(hm1246->reset_gpio),
> > > +				     "failed to get reset GPIO\n");
> > 
> > Rely on the reset-gpio driver instead of this.
> 
> Do you mean that I should use devm_reset_control_get_optional, for example,
> to handle the reset GPIO pin?
> Unless I've missed something, no I2C image sensor seems to use that.
> The recently added driver for the OV2735 also uses the standard GPIO
> framework for the reset pin.

The driver is kinda new (a year and half old), nevertheless I see
disadvantages, it's OF-centric and makes little sense for most of
the users (discrete components).

> For these reasons, I'm not quite sure if I've understood this correctly.

-- 
With Best Regards,
Andy Shevchenko