[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251020-talented-inquisitive-bulldog-64aba0@kuoka>
Date: Mon, 20 Oct 2025 12:09:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ram Prakash Gupta <quic_rampraka@...cinc.com>,
Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, dmitry.baryshkov@....qualcomm.com,
quic_pragalla@...cinc.com, quic_sayalil@...cinc.com, quic_nitirawa@...cinc.com,
quic_bhaskarv@...cinc.com, kernel@....qualcomm.com,
Sachin Gupta <quic_sachgupt@...cinc.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: mmc: Add dll-presets values for
HS400 and HS200 modes
On Tue, Oct 14, 2025 at 02:06:46AM +0200, Krzysztof Kozlowski wrote:
> On 13/10/2025 16:53, Ram Prakash Gupta wrote:
> > From: Sachin Gupta <quic_sachgupt@...cinc.com>
> >
> > Document the 'dll-presets' property for MMC device tree bindings.
> > The 'dll-presets' property defines the DLL configurations for HS400
> > and HS200 modes.
> >
> > QC SoCs can have 0 to 4 SDHCI instances, and each one may need
> > different tuning.
> >
> > Signed-off-by: Sachin Gupta <quic_sachgupt@...cinc.com>
> > Signed-off-by: Ram Prakash Gupta <quic_rampraka@...cinc.com>
> > ---
> > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > index 594bd174ff21..f7b3b1ced3ce 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > @@ -138,6 +138,11 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description: platform specific settings for DLL_CONFIG reg.
> >
> > + qcom,dll-presets:
> > + maxItems: 10
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description: platform specific settings for DLL registers.
>
> One of my questions, never answered in original submission and in your
> versions, was to see the DTS user of it. I still do not see the DTS user.
There is no answer, so I mark the patch as changes requested.
Best regards,
Krzysztof
Powered by blists - more mailing lists