linux-kernel - Re: [RFC PATCH] can: gs_usb: fix kernel oops during restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251020-aspiring-agama-of-agreement-6d1727-mkl@blackshift.org>
Date: Mon, 20 Oct 2025 12:12:15 +0200
From: Marc Kleine-Budde <mkl@...ckshift.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Andrei Lalaev <andrey.lalaev@...il.com>, mailhol.vincent@...adoo.fr, 
	linux-kernel@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [RFC PATCH] can: gs_usb: fix kernel oops during restart

On 15.07.2025 11:37:15, Marc Kleine-Budde wrote:
> What about this fix?
> 
> diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
> index 13826e8a707b..94603c9eb4aa 100644
> --- a/drivers/net/can/dev/netlink.c
> +++ b/drivers/net/can/dev/netlink.c
> @@ -285,6 +285,12 @@ static int can_changelink(struct net_device *dev, struct nlattr *tb[],
>          }
>  
>          if (data[IFLA_CAN_RESTART_MS]) {
> +                if (!priv->do_set_mode) {
> +                        NL_SET_ERR_MSG(extack,
> +                                       "device doesn't support restart from Bus Off");
> +                        return -EOPNOTSUPP;
> +                }
> +

Damn. This causes a regression on systemd-network:

| systemd-networkd[1532939]: can0: Failed to set CAN interface configurations: Device doesn't support restart from Bus Off. Operation not supported
| systemd-networkd[1532939]: can0: Failed
| systemd-networkd[1532939]: can0: Trying to reconfigure the interface.
| systemd-networkd[1532939]: can0: Reconfiguring with /etc/systemd/network/90-can.network.

Since v258-rc1 restart delays of 0 are configured, prior to this, they
were ignored.

I'll send a fix that allows configuring a restart delay of 0, even if
the device doesn't have a restart handler.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)