linux-kernel - Re: [PATCH] sched: Remove unused variable in mm_cid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75a8f465-f831-4bf9-a48f-94c05470e900@arm.com>
Date: Mon, 20 Oct 2025 12:34:44 +0200
From: Kevin Brodsky <kevin.brodsky@....com>
To: Christian Loehle <christian.loehle@....com>,
 linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH] sched: Remove unused variable in mm_cid_get()

On 20/10/2025 12:16, Christian Loehle wrote:
> On 10/17/25 08:30, Kevin Brodsky wrote:
>> The cpumask variable in mm_cid_get() has never been used, remove it.
>>
>> This fixes a -Wunused-but-set-variable warning when building with
>> W=1.
>>
>> Signed-off-by: Kevin Brodsky <kevin.brodsky@....com>
>> ---
>> Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Juri Lelli <juri.lelli@...hat.com>
>> ---
>>  kernel/sched/sched.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>> index 1f5d07067f60..361f9101cef9 100644
>> --- a/kernel/sched/sched.h
>> +++ b/kernel/sched/sched.h
>> @@ -3740,11 +3740,9 @@ static inline int mm_cid_get(struct rq *rq, struct task_struct *t,
>>  			     struct mm_struct *mm)
>>  {
>>  	struct mm_cid __percpu *pcpu_cid = mm->pcpu_cid;
>> -	struct cpumask *cpumask;
>>  	int cid;
>>  
>>  	lockdep_assert_rq_held(rq);
>> -	cpumask = mm_cidmask(mm);
>>  	cid = __this_cpu_read(pcpu_cid->cid);
>>  	if (mm_cid_is_valid(cid)) {
>>  		mm_cid_snapshot_time(rq, mm);
>>
>> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> Andy also posted this:
> https://lore.kernel.org/lkml/20251015091935.2977229-1-andriy.shevchenko@linux.intel.com/

Ah I missed it, thanks! Please ignore my patch then (especially since it
misses a Fixes: tag).

- Kevin