linux-kernel - Re: [PATCH v3 06/14] iommu/mediatek: fix use-after-free on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0b8e58-1389-4409-abdc-a66232a70d4a@collabora.com>
Date: Mon, 20 Oct 2025 12:35:56 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Johan Hovold <johan@...nel.org>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>
Cc: Robin Murphy <robin.murphy@....com>, Sven Peter <sven@...nel.org>,
 Janne Grunau <j@...nau.net>, Rob Clark <robin.clark@....qualcomm.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>, Yong Wu <yong.wu@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>, Chen-Yu Tsai <wens@...e.org>,
 Thierry Reding <thierry.reding@...il.com>, Krishna Reddy
 <vdumpa@...dia.com>, iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v3 06/14] iommu/mediatek: fix use-after-free on probe
 deferral

Il 20/10/25 06:53, Johan Hovold ha scritto:
> The driver is dropping the references taken to the larb devices during
> probe after successful lookup as well as on errors. This can
> potentially lead to a use-after-free in case a larb device has not yet
> been bound to its driver so that the iommu driver probe defers.
> 
> Fix this by keeping the references as expected while the iommu driver is
> bound.
> 
> Fixes: 26593928564c ("iommu/mediatek: Add error path for loop of mm_dts_parse")
> Cc: stable@...r.kernel.org
> Cc: Yong Wu <yong.wu@...iatek.com>
> Acked-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>