linux-kernel - Re: [PATCH] ARM: dts: imx6ull-engicam-microgea-rmm: fix report-rate-hz value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPYkZXCtXyYYprp6@dragon>
Date: Mon, 20 Oct 2025 20:00:37 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
	Michael Trimarchi <michael@...rulasolutions.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Fabio Estevam <festevam@...il.com>, Frank Li <Frank.Li@....com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Peng Fan <peng.fan@....com>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Rob Herring <robh@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6ull-engicam-microgea-rmm: fix
 report-rate-hz value

On Sat, Sep 13, 2025 at 11:16:31AM +0200, Dario Binacchi wrote:
> The 'report-rate-hz' property for the edt-ft5x06 driver was added and
> handled in the Linux kernel by me with patches [1] and [2] for this
> specific board.
> 
> The v1 upstream version, which was the one applied to the customer's
> kernel, used the 'report-rate' property, which was written directly to
> the controller register. During review, the 'hz' suffix was added,
> changing its handling so that writing the value directly to the register
> was no longer possible for the M06 controller.
> 
> Once the patches were accepted in mainline, I did not reapply them to
> the customer's kernel, and when upstreaming the DTS for this board, I
> forgot to correct the 'report-rate-hz' property value.
> 
> The property must be set to 60 because this board uses the M06 controller,
> which expects the report rate in units of 10 Hz, meaning the actual value
> written to the register is 6.
> 
> [1] 625f829586ea ("dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz")
> [2] 5bcee83a406c ("Input: edt-ft5x06 - set report rate by dts property")
> Fixes: ffea3cac94ba ("ARM: dts: imx6ul: support Engicam MicroGEA RMM board")
> Co-developed-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

Applied, thanks!